ok, whats wrong with this?

[LSK]

CASE WHEN ( PODT00 > 0 ) THEN
CASE WHEN ( PODT00 - SDDT00 ) < 0 THEN 0
WHEN SDTM00 = 1700 THEN 0
WHEN SDTM00 < POTM00 THEN CAST ((CAST(CAST(CONCAT(CONCAT(CONCAT(SUBSTRING(CAST((CASE WHEN SDTM00 > 1259 THEN (CAST(CONCAT(SUBSTR(CAST(SDTM00 AS VARCHAR ( 4 ) ) , 1 , 2 ) , SUBSTR ( CAST ( SDTM00 AS VARCHAR ( 4 ) ) , 3 , 2 ) ) AS NUMERIC ( 4 , 0 ) ) - 1200 ) ELSE SDTM00 END )
AS VARCHAR ( 4 ) ) , 1 , ( CASE WHEN LENGTH ( CAST ( ( CASE WHEN SDTM00 > 1259 THEN ( CAST ( CONCAT ( SUBSTR ( CAST ( SDTM00 AS VARCHAR ( 4 ) ) , 1 , 2 ) , SUBSTR ( CAST ( SDTM00 AS VARCHAR ( 4 ) ) , 3 , 2 ) ) AS NUMERIC ( 4 , 0 ) ) - 1200 ) ELSE SDTM00 END ) AS VARCHAR ( 4 ) ) ) = 3 THEN 1 ELSE 2 END ) ) , ':' ) , SUBSTRING ( CAST ( SDTM00 AS VARCHAR ( 4 ) ) , ( CASE WHEN LENGTH ( CAST ( SDTM00 AS VARCHAR ( 4 ) ) ) = 3 THEN 2 ELSE 3 END ) , 2 ) ) , ( CASE WHEN SDTM00 < 1200 THEN ' AM' ELSE ' PM' END ) ) AS TIME )
- CAST ( CONCAT ( CONCAT ( CONCAT ( SUBSTRING ( CAST ( ( CASE WHEN POTM00 > 1259 THEN ( CAST ( CONCAT ( SUBSTR ( CAST ( POTM00 AS VARCHAR ( 4 ) ) , 1 , 2 ) , SUBSTR ( CAST ( POTM00 AS VARCHAR ( 4 ) ) , 3 , 2 ) ) AS NUMERIC ( 4 , 0 ) ) - 1200 ) ELSE POTM00 END ) AS VARCHAR ( 4 ) ) , 1 , ( CASE WHEN LENGTH ( CAST ( ( CASE WHEN POTM00 > 1259 THEN ( CAST ( CONCAT ( SUBSTR ( CAST ( POTM00 AS VARCHAR ( 4 ) ) , 1 , 2 ) , SUBSTR ( CAST ( POTM00 AS VARCHAR ( 4 ) ) , 3 , 2 ) ) AS NUMERIC ( 4 , 0 ) ) - 1200 ) ELSE POTM00 END ) AS VARCHAR ( 4 ) ) ) = 3 THEN 1 ELSE 2 END ) ) , ':' ) , SUBSTRING ( CAST ( POTM00 AS VARCHAR ( 4 ) ) , ( CASE WHEN LENGTH ( CAST ( POTM00 AS VARCHAR ( 4 ) ) ) = 3 THEN 2 ELSE 3 END ) , 2 ) ) , ( CASE WHEN POTM00 < 1200 THEN 'AM' ELSE ' PM' END ) ) AS TIME ) AS NUMERIC ( 8 , 0 ) ) / 100 ) AS NUMERIC ( 8 , 0 ) ) ELSE 0 END WHEN ADTM00 > 0 THEN CASE WHEN ( ADDT00 - SDDT00 ) < 0 THEN 0 WHEN SDTM00 = 1700 THEN 0 WHEN SDTM00 < ADTM00 THEN CAST ( ( CAST ( CAST ( CONCAT ( CONCAT( CONCAT ( SUBSTRING ( CAST ( ( CASE WHEN SDTM00 > 1259 THEN ( CAST ( CONCAT ( SUBSTR ( CAST ( SDTM00 AS VARCHAR ( 4 ) ) , 1 , 2 ) , SUBSTR ( CAST ( SDTM00 AS VARCHAR ( 4 ) ) , 3 , 2 ) ) AS NUMERIC ( 4 , 0 ) ) - 1200 ) ELSE SDTM00 END ) AS VARCHAR ( 4 ) ) , 1 , ( CASE WHEN LENGTH ( CAST ( ( CASE WHEN SDTM00 > 1259 THEN ( CAST ( CONCAT ( SUBSTR ( CAST ( SDTM00 AS VARCHAR ( 4 ) ) , 1 , 2 ) , SUBSTR ( CAST ( SDTM00 AS VARCHAR ( 4 ) ) , 3 , 2 ) ) AS NUMERIC ( 4 , 0 ) ) - 1200 ) ELSE SDTM00 END ) AS VARCHAR ( 4 ) ) ) = 3 THEN 1 ELSE 2 END ) ) , ':' ) , SUBSTRING ( CAST ( SDTM00 AS VARCHAR ( 4 ) ) , ( CASE WHEN LENGTH ( CAST ( SDTM00 AS VARCHAR ( 4 ) ) ) = 3 THEN 2 ELSE 3 END ) , 2 ) ) , ( CASE WHEN SDTM00 < 1200 THEN ' AM' ELSE ' PM' END ) ) AS TIME ) - CAST ( CONCAT ( CONCAT ( CONCAT ( SUBSTRING ( CAST ( ( CASE WHEN ADTM00 > 1259 THEN ( CAST ( CONCAT ( SUBSTR ( CAST ( ADTM00 AS VARCHAR ( 4 ) ) , 1 , 2 ) , SUBSTR ( CAST ( ADTM00 AS VARCHAR ( 4 ) ) , 3 , 2 ) ) AS NUMERIC ( 4 , 0 ) ) - 1200 ) ELSE ADTM00 END ) AS VARCHAR ( 4 ) ) , 1 , ( CASE WHEN LENGTH ( CAST ( ( CASE WHEN ADTM00 > 1259 THEN ( CAST ( CONCAT ( SUBSTR ( CAST ( ADTM00 AS VARCHAR ( 4 ) ) , 1 , 2 ) , SUBSTR ( CAST ( ADTM00 AS VARCHAR ( 4 ) ) , 3 , 2 ) ) AS NUMERIC ( 4 , 0 ) ) - 1200 ) ELSE ADTM00 END ) AS VARCHAR ( 4 ) ) ) = 3 THEN 1 ELSE 2 END ) ) , ':' ) , SUBSTRING ( CAST ( ADTM00 AS VARCHAR ( 4 ) ) , ( CASE WHEN LENGTH ( CAST ( ADTM00 AS VARCHAR ( 4 ) ) ) = 3 THEN 2 ELSE 3 END ) , 2 ) ) , ( CASE WHEN ADTM00 < 1200 THEN ' AM' ELSE ' PM' END ) ) AS TIME ) AS NUMERIC ( 8 , 0 ) ) / 100 ) AS NUMERIC ( 8 , 0 ) ) ELSE 0 END ELSE 0 END AS TIMEDIF

[LaurenG]

1. endless loop?

it's too hard for me to tell.:shrug:

[flvegan]

2. It's all in caps, which is poor netiquette.

I'm an idiot.

[Misunderestimator]

3. First, you need to format it so that it's readable.

[LSK]

4. that would be half the battle

unfornately thats how i got it

[Misunderestimator]

6. That would be my first step.

There would be no way to even approach it without formatting with returns and indents first. I do that all the time when evaluating system generated errors that contain SQL or Cobol statements that fail. They are usually not formatted after compilation, even when the actual program is.

[Misunderestimator]

12. Oh man.... That sucks... Too many nested "cases" to start with.

That's nearly impossible to even make readable. Holy crap. What crap SQL did that come from? And why does it use both SUBSTR and SUBSTRING as functions?

[LSK]

13. someone else wrote it (who no longer works here)

It errors out occasinally.

[Misunderestimator]

14. Of course it does... it errors whenever it evaluates to the case statement

that sucks worse than all the others. Holy shit, man... that code really really really sucks. I would throw it out and start from scratch from the requirement. That would be nearly impossible to figure out. All the substrings and casts which should be call outs from the main program... It just plain sucks.

Under what conditions does it fail? What's the value of SDTM00, POTM00 and ADTM00 when it fails? That's the place to start so you can narrow it down to the exact location of the sucky code.

On edit... just had a thought... maybe SUBSTRING is not a valid function? There are more SUBSTRs than SUBSTRINGs in the code, so it's possible it fails whenever it evaluates to a portion of the code that uses the SUBSTRING function.

[EstimatedProphet]

5. You forgot a comma

[Rabrrrrrr]

7. What language is that?

Even cobol isn't that ugly.

[salvorhardin]

8. It looks like really horrible C code n/t

[Rabrrrrrr]

10. I would bet good money that's not C

I've done C, and it doesn't look familiar, and there're no brackets and no semi-colons.

[salvorhardin]

15. No.. I didn't mean to imply that it WAS C code

I just meant to say it LOOKED like really horrible C code. In particular all those type castings -- ugh! I should have clarified in the body of my message.

Got to love the meaningless identifiers too.

[LSK]

11. SQL

[salvorhardin]

16. Really!?

Wow. I've never seen SQL like that before. What kind of system is it from?

Just curious. I certainly don't envy you.

[LSK]

17. its part of a select statement

Its DB2.

[Orsino]

9. I see the mistake.

You misspelled "* is a spoiled brat whose strings are pulled by dangerous ideologue cronies who are wrecking our economy and culture as they kill thousands."

[LynzM]

18. Holy shit, dude.

I've written some messy SQL in my learning of it, but that's a fucking disaster. Wow. Good luck. I agree with MisU's suggestion to figure out what it's supposed to do and rewrite it, I think. Ugh.